Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of length defined data fields in FIX messages #625

Conversation

larsope
Copy link
Contributor

@larsope larsope commented Jul 2, 2020

  • Added ExctractDataField method that is called when the parser comes across a FIX data field that has a defined length given by a previous tag.
  • Added a unit test to DataDictionaryTests to verify that a message is
    read correctly

… across a FIX data field that has a defined length given by a previous

tag.
- Added a unit test to DataDictionaryTests to verify that a message is
read correctly
@CLAassistant
Copy link

CLAassistant commented Jul 2, 2020

CLA assistant check
All committers have signed the CLA.

@larsope
Copy link
Contributor Author

larsope commented Jul 2, 2020

This pull request is intended to directly address the handling of the XML non-FIX payload message defined by the CME.
https://www.cmegroup.com/confluence/display/EPICSANDBOX/Drop+Copy+4.0#DropCopy4.0-EncapsulatedXMLNon-Fix(tag35-MsgType=n)Message

This issue was addressed in the C++ version of QuickFIX in the extractField method of the message class as well.

@larsope
Copy link
Contributor Author

larsope commented Jul 23, 2020

This fix can be linked to issue #301 as a solution

@gbirchmeier
Copy link
Member

@larsope Looks like most of this one was ported over to your #782 (which I rebased into #832).

Can I close this?

Furthermore, it looks like I can probably close #301 also. Do you agree?

@gbirchmeier
Copy link
Member

I'm closing this, per previous comment. If I'm mistaken, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants